fix(vehicles): add logging if a non-shuttle vehicle has a null direction_id #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudiejd
requested review from
a team and
lemald
and removed request for
a team
rudiejd
force-pushed
the
fix/add-logging-when-direction_id_null
branch
from
1d16be3 to
68aab4e
Compare
lemald
reviewed
Jan 22, 2025
lemald
reviewed
Jan 22, 2025
|
question: would it be possible to add a quick unit test for this? |
Co-authored-by: Eddie Maldonado <[email protected]>
|
@lemald yep, I can add one. I wasn't sure whether we wanted to test logging logic |
It's definitely not our top priority for automated testing but I personally like doing it where feasible, especially for something like this where the situation isn't regularly occurring for us to test the logging manually. |
lemald
reviewed
Jan 22, 2025
lemald
reviewed
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: 🍎🐛 v3 API returning null direction_id in certain cases
Problem: As described in the linked ticket, sometimes we return vehicles with
"direction_id": null. We aren't sure why. I spent a couple of days looking into this issue and didn't make any progress.Solution: We are adding logs for when an invalid
direction_idis returned. Hopefully these can allow us to better ascertain what conditions lead to this happening.